cryptoophelper: requested code must be saved between instances!

This commit is contained in:
Vincent Breitmoser
2015-07-09 02:35:22 +02:00
parent a549938b61
commit 7f9cc445fb
2 changed files with 27 additions and 1 deletions

View File

@@ -20,6 +20,7 @@ package org.sufficientlysecure.keychain.ui.base;
import android.content.Context;
import android.content.Intent;
import android.os.Bundle;
import android.os.Parcelable;
import android.support.annotation.Nullable;
import android.support.v4.app.Fragment;
@@ -62,6 +63,18 @@ abstract class CryptoOperationFragment<T extends Parcelable, S extends Operation
mOperationHelper = new CryptoOperationHelper<>(this, this, R.string.progress_processing);
}
@Override
public void onCreate(@Nullable Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
mOperationHelper.onRestoreInstanceState(savedInstanceState);
}
@Override
public void onSaveInstanceState(Bundle outState) {
super.onSaveInstanceState(outState);
mOperationHelper.onSaveInstanceState(outState);
}
@Override
public void onActivityResult(int requestCode, int resultCode, Intent data) {
mOperationHelper.handleActivityResult(requestCode, resultCode, data);

View File

@@ -26,6 +26,7 @@ import android.os.Bundle;
import android.os.Message;
import android.os.Messenger;
import android.os.Parcelable;
import android.support.annotation.Nullable;
import android.support.v4.app.Fragment;
import android.support.v4.app.FragmentActivity;
import android.support.v4.app.FragmentManager;
@@ -53,6 +54,8 @@ import org.sufficientlysecure.keychain.util.Log;
*/
public class CryptoOperationHelper<T extends Parcelable, S extends OperationResult> {
public static final String ARG_REQUESTED_CODE = "requested_code";
public interface Callback<T extends Parcelable, S extends OperationResult> {
T createOperationInput();
@@ -102,6 +105,17 @@ public class CryptoOperationHelper<T extends Parcelable, S extends OperationResu
mCallback = callback;
}
public void onSaveInstanceState(Bundle outState) {
outState.putInt(ARG_REQUESTED_CODE, mRequestedCode);
}
public void onRestoreInstanceState(@Nullable Bundle state) {
if (state == null) {
return;
}
mRequestedCode = state.getInt(ARG_REQUESTED_CODE, -1);
}
public void setProgressMessageResource(int id) {
mProgressMessageResource = id;
}
@@ -325,6 +339,5 @@ public class CryptoOperationHelper<T extends Parcelable, S extends OperationResu
throw new AssertionError("bad return class ("
+ result.getClass().getSimpleName() + "), this is a programming error!");
}
}
}