cthrace/open-keychain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add @CheckResult to Notify.create() to prevent misuse

Browse Source
This commit is contained in:
Christian Hagau
2017-10-23 00:00:00 +00:00
parent e18ca42789
commit 33bc407e7a
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/Notify.java
View File

@@ -18,6 +18,7 @@
package org.sufficientlysecure.keychain.ui.util; package org.sufficientlysecure.keychain.ui.util;
import android.app.Activity; import android.app.Activity;
import android.support.annotation.CheckResult;
import android.support.v4.app.Fragment; import android.support.v4.app.Fragment;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
@@ -55,6 +56,7 @@ public class Notify {
public static final int LENGTH_LONG = 3500; public static final int LENGTH_LONG = 3500;
public static final int LENGTH_SHORT = 1500; public static final int LENGTH_SHORT = 1500;
@CheckResult
public static Showable create(final Activity activity, String text, int duration, Style style, public static Showable create(final Activity activity, String text, int duration, Style style,
final ActionListener actionListener, Integer actionResId) { final ActionListener actionListener, Integer actionResId) {
final Snackbar snackbar = Snackbar.with(activity) final Snackbar snackbar = Snackbar.with(activity)
@@ -134,28 +136,34 @@ public class Notify {
}; };
} }
@CheckResult
public static Showable create(Activity activity, String text, int duration, Style style) { public static Showable create(Activity activity, String text, int duration, Style style) {
return create(activity, text, duration, style, null, null); return create(activity, text, duration, style, null, null);
} }
@CheckResult
public static Showable create(Activity activity, String text, Style style) { public static Showable create(Activity activity, String text, Style style) {
return create(activity, text, LENGTH_LONG, style); return create(activity, text, LENGTH_LONG, style);
} }
@CheckResult
public static Showable create(Activity activity, int textResId, Style style, public static Showable create(Activity activity, int textResId, Style style,
ActionListener actionListener, int actionResId) { ActionListener actionListener, int actionResId) {
return create(activity, textResId, LENGTH_LONG, style, actionListener, actionResId); return create(activity, textResId, LENGTH_LONG, style, actionListener, actionResId);
} }
@CheckResult
public static Showable create(Activity activity, int textResId, int duration, Style style, public static Showable create(Activity activity, int textResId, int duration, Style style,
ActionListener actionListener, int actionResId) { ActionListener actionListener, int actionResId) {
return create(activity, activity.getString(textResId), duration, style, actionListener, actionResId); return create(activity, activity.getString(textResId), duration, style, actionListener, actionResId);
} }
@CheckResult
public static Showable create(Activity activity, int textResId, int duration, Style style) { public static Showable create(Activity activity, int textResId, int duration, Style style) {
return create(activity, activity.getString(textResId), duration, style); return create(activity, activity.getString(textResId), duration, style);
} }
@CheckResult
public static Showable create(Activity activity, int textResId, Style style) { public static Showable create(Activity activity, int textResId, Style style) {
return create(activity, activity.getString(textResId), style); return create(activity, activity.getString(textResId), style);
} }