From 33bc407e7ac9145654e4cb96afe3d2a23d22b47b Mon Sep 17 00:00:00 2001
From: Christian Hagau <ach@hagau.se>
Date: Mon, 23 Oct 2017 00:00:00 +0000
Subject: [PATCH] Add @CheckResult to Notify.create() to prevent misuse

---
 .../org/sufficientlysecure/keychain/ui/util/Notify.java   | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/Notify.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/Notify.java
index 71f6ecc1a..84f97ba4a 100644
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/Notify.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/Notify.java
@@ -18,6 +18,7 @@
 package org.sufficientlysecure.keychain.ui.util;
 
 import android.app.Activity;
+import android.support.annotation.CheckResult;
 import android.support.v4.app.Fragment;
 import android.view.View;
 import android.view.ViewGroup;
@@ -55,6 +56,7 @@ public class Notify {
     public static final int LENGTH_LONG = 3500;
     public static final int LENGTH_SHORT = 1500;
 
+    @CheckResult
     public static Showable create(final Activity activity, String text, int duration, Style style,
                                   final ActionListener actionListener, Integer actionResId) {
         final Snackbar snackbar = Snackbar.with(activity)
@@ -134,28 +136,34 @@ public class Notify {
         };
     }
 
+    @CheckResult
     public static Showable create(Activity activity, String text, int duration, Style style) {
         return create(activity, text, duration, style, null, null);
     }
 
+    @CheckResult
     public static Showable create(Activity activity, String text, Style style) {
         return create(activity, text, LENGTH_LONG, style);
     }
 
+    @CheckResult
     public static Showable create(Activity activity, int textResId, Style style,
             ActionListener actionListener, int actionResId) {
         return create(activity, textResId, LENGTH_LONG, style, actionListener, actionResId);
     }
 
+    @CheckResult
     public static Showable create(Activity activity, int textResId, int duration, Style style,
                                   ActionListener actionListener, int actionResId) {
         return create(activity, activity.getString(textResId), duration, style, actionListener, actionResId);
     }
 
+    @CheckResult
     public static Showable create(Activity activity, int textResId, int duration, Style style) {
         return create(activity, activity.getString(textResId), duration, style);
     }
 
+    @CheckResult
     public static Showable create(Activity activity, int textResId, Style style) {
         return create(activity, activity.getString(textResId), style);
     }