cthrace/open-keychain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6,512 Commits 1 Branch 0 Tags
778fb8e94acd1483c163aefc02517f8676301798
Commit Graph

3467 Commits

Author SHA1 Message Date
Vincent Breitmoser
778fb8e94a Retain RSA key format when setting key attributes in putKey operation 
For the put secret key operation, openpgp applet implementations differ
in their handling of attributes:

- there are four formats for sending key data: standard, standard with
  modulus, with crt, and with crt and modulus.
- the key attributes (modulus length, public exponent length, key
  format) can not be changed on all cards. changing them is only
  necessary for cards that support different key lengths (that is,
  RSA 4096)
- on the cards where they *can* be changed, not all parameters might be
  changeable. in particular, modulus length may be changeable but not
  key format.

Because of this constellation, the put key operation now only sets the
modulus of the key, while retaining the key format. At the time of
writing, the Gnuk and Nitrokey use the standard format, while the
Yubikey and other applets use crt+modulus.

This fixes loading keys into the Nitrokey Pro, and partially for the
Gnuk token.
 2017-10-30 21:45:38 +01:00
Vincent Breitmoser
5f622339b1 Output usb data to debug log 2017-10-30 17:01:49 +01:00
Vincent Breitmoser
83b6c0e2f0 use correct max packet size in CcidReceiver 2017-10-29 02:42:26 +02:00
Vincent Breitmoser
0021c1f15f add tests for CcidTransceiver 2017-10-29 02:42:26 +02:00
Vincent Breitmoser
8b07428ec0 document T1TpduProtocol slighly better 2017-10-28 23:32:07 +02:00
Vincent Breitmoser
19dc0db89b add gnuk to supported tokens 2017-10-28 23:32:03 +02:00
Nikita Mikhailov
06b5a878c5 SecurityToken: more robust voltage selection 2017-10-28 23:31:57 +02:00
Vincent Breitmoser
95034e36b1 fix unit test 2017-10-26 17:44:13 +02:00
Vincent Breitmoser
b6236bde59 determine token type during connect 2017-10-26 17:20:13 +02:00
Vincent Breitmoser
8649332bdc don't distinguish unknown tokens by transport 2017-10-26 17:20:13 +02:00
Dominik Schürmann
ed4e21957c Better error handling for generic IOException 2017-10-26 17:20:13 +02:00
Dominik Schürmann
0920d97572 Check for security token support 2017-10-26 17:20:13 +02:00
Dominik Schürmann
e7705eaca8 Use constants for vendor and product IDs 2017-10-26 17:20:12 +02:00
Vincent Breitmoser
14b74b7590 add token transport and type to SecurityTokenInfo 2017-10-26 17:19:22 +02:00
Dominik Schürmann
0ca46c46aa Route all class 11 USB devices to OpenKeychain, some class 3 for info 2017-10-26 12:28:32 +02:00
Dominik Schürmann
60b970b060 Merge pull request #2186 from open-keychain/apdu-refactor 
Refactor OpenPGP applet communication code
 2017-10-26 12:26:55 +02:00
Christian Hagau
c435c3ec22 Fix NPE upon dialog dismissal 2017-10-25 00:00:00 +00:00
Vincent Breitmoser
0bb32fad2a Merge pull request #2194 from open-keychain/remove-fp-color 
Remove colorization of fingerprints
 2017-10-24 01:17:46 +02:00
Vincent Breitmoser
f41debb0e9 Merge pull request #2193 from hagau/fix_notifications 
Fix showing of some notifications
 2017-10-23 21:17:05 +02:00
Vincent Breitmoser
7eb37a89d8 reduce number of token roundtrips used to obtain SecurityTokenInfo 2017-10-23 20:40:25 +02:00
Vincent Breitmoser
2812f07d34 add rudimentary unit test for SecurityTokenConnection 2017-10-23 20:40:25 +02:00
Vincent Breitmoser
c295a6815f write nfc communication to debug output 2017-10-23 20:40:25 +02:00
Vincent Breitmoser
911d2a1c96 rewrite CommandApdu 2017-10-23 20:40:25 +02:00
Vincent Breitmoser
c89aab8802 reduce visibility where unnecessary 2017-10-23 20:40:25 +02:00
Vincent Breitmoser
a4af2f7f5c rewrite ResponseApdu 2017-10-23 20:40:25 +02:00
Vincent Breitmoser
e8103d8376 use reset instead of modify for changing pw1 2017-10-23 20:40:25 +02:00
Vincent Breitmoser
9b292a4c70 rename CommandAPDUFactory -> OpenPgpCommandApduFactory 2017-10-23 20:40:25 +02:00
Vincent Breitmoser
b7723c1a4a replace magic constants in APDU factory 2017-10-23 20:40:25 +02:00
Vincent Breitmoser
8e9a62070d extract creation of CommandAPDUs into factory 2017-10-23 20:40:25 +02:00
Vincent Breitmoser
46b69d45c4 explicitly pass around instance of SecurityTokenConnection 2017-10-23 20:40:25 +02:00
Vincent Breitmoser
e8f72718e9 rename SecurityTokenHelper to SecurityTokenConnection 2017-10-23 20:38:04 +02:00
Dominik Schürmann
cd65505890 Remove colorization of fingerprints 2017-10-23 18:43:41 +02:00
Dominik Schürmann
07b7936d0b Merge pull request #2183 from open-keychain/locate-hotspot 
Add "Where is my NFC reader?" button to nfc waiting dialog
 2017-10-23 18:37:15 +02:00
Christian Hagau
80be81adb3 Fix showing of some notifications 2017-10-23 14:57:36 +00:00
Christian Hagau
33bc407e7a Add @CheckResult to Notify.create() to prevent misuse 2017-10-23 14:57:36 +00:00
Wiktor Kwapisiewicz
f2cda5dd6c Accept dash character (-) in GitHub user names when checking for Gist URL 
GitHub allows dash / minus characters in usernames (e.g. "wiktor-k" or
"open-keychain"). This change extends the regular expression to capture
this missing character.
 2017-10-18 21:20:25 +02:00
Vincent Breitmoser
dfed7d3c93 Move decision of whether to show button into ShowNfcSweetspotActivity 2017-10-12 10:05:04 +02:00
Vincent Breitmoser
287d3251c5 Add "Where is my NFC reader?" feature to nfc waiting dialog 2017-10-10 05:06:40 +02:00
Vincent Breitmoser
c07e808d24 add nfc sweetspot data, scraped from NFC-Ring API 2017-10-10 04:54:43 +02:00
Vincent Breitmoser
0cb000a0be Change some package structure 2017-10-09 14:24:42 +02:00
Vincent Breitmoser
a51252910b some T=1 refactoring 2017-10-09 14:17:30 +02:00
Vincent Breitmoser
6cc058e25f some more cleanup in usb classes 2017-10-08 05:01:40 +02:00
Vincent Breitmoser
31da4c450d Ignore leading data before IccPowerOn operation in CcidTransceiver 2017-10-08 05:01:39 +02:00
Vincent Breitmoser
7a24f4c237 refactor CcidTransceiver 2017-10-08 05:01:25 +02:00
Vincent Breitmoser
65c1ca91d4 explicitly connect before writing to output stream while creating github linked id 2017-10-06 19:19:35 +02:00
Vincent Breitmoser
c4905c5eda increase timeouts for github account linking 2017-10-06 19:07:54 +02:00
Vincent Breitmoser
fa3345f595 fix base64 encoding for github auth revocation 2017-10-06 19:07:40 +02:00
Vincent Breitmoser
2debc23ce0 slightly nicer error reporting for security token cla chaining 2017-10-06 19:06:43 +02:00
Vincent Breitmoser
618c3a506c Merge pull request #2167 from open-keychain/ditch-consolidate 
Ditch "consolidate" mechanism
 2017-10-02 16:46:12 +02:00
Vincent Breitmoser
4536645170 don't show "link account" button if feature is disabled 2017-09-30 21:19:20 +02:00