diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/linked/LinkedIdCreateHttpsStep2Fragment.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/linked/LinkedIdCreateHttpsStep2Fragment.java index e8b350058..f6e90c28c 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/linked/LinkedIdCreateHttpsStep2Fragment.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/linked/LinkedIdCreateHttpsStep2Fragment.java @@ -49,7 +49,6 @@ public class LinkedIdCreateHttpsStep2Fragment extends LinkedIdCreateFinalFragmen EditText mEditUri; URI mResourceUri; - String mResourceString; public static LinkedIdCreateHttpsStep2Fragment newInstance(String uri) { @@ -77,8 +76,6 @@ public class LinkedIdCreateHttpsStep2Fragment extends LinkedIdCreateFinalFragmen Timber.e(e); requireActivity().finish(); } - - mResourceString = GenericHttpsResource.generateText(requireActivity(), fingerprint); } @Override @@ -100,10 +97,14 @@ public class LinkedIdCreateHttpsStep2Fragment extends LinkedIdCreateFinalFragmen return view; } + private String getResourceString() { + return GenericHttpsResource.generateText(requireActivity(), fingerprint); + } + private void proofSend() { Intent sendIntent = new Intent(); sendIntent.setAction(Intent.ACTION_SEND); - sendIntent.putExtra(Intent.EXTRA_TEXT, mResourceString); + sendIntent.putExtra(Intent.EXTRA_TEXT, getResourceString()); sendIntent.setType("text/plain"); startActivity(sendIntent); } @@ -124,7 +125,7 @@ public class LinkedIdCreateHttpsStep2Fragment extends LinkedIdCreateFinalFragmen private void saveFile(Uri uri) { try { PrintWriter out = new PrintWriter(requireActivity().getContentResolver().openOutputStream(uri)); - out.print(mResourceString); + out.print(getResourceString()); if (out.checkError()) { Notify.create(getActivity(), "Error writing file!", Style.ERROR).show(); } diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/linked/LinkedIdCreateTwitterStep2Fragment.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/linked/LinkedIdCreateTwitterStep2Fragment.java index 7e5ca0051..37be1b89c 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/linked/LinkedIdCreateTwitterStep2Fragment.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/linked/LinkedIdCreateTwitterStep2Fragment.java @@ -40,7 +40,6 @@ public class LinkedIdCreateTwitterStep2Fragment extends LinkedIdCreateFinalFragm public static final String ARG_HANDLE = "handle"; String mResourceHandle; - String mResourceString; public static LinkedIdCreateTwitterStep2Fragment newInstance(String handle) { LinkedIdCreateTwitterStep2Fragment frag = new LinkedIdCreateTwitterStep2Fragment(); @@ -56,10 +55,13 @@ public class LinkedIdCreateTwitterStep2Fragment extends LinkedIdCreateFinalFragm public void onActivityCreated(@Nullable Bundle savedInstanceState) { super.onActivityCreated(savedInstanceState); - mResourceString = TwitterResource.generate(fingerprint); mResourceHandle = getArguments().getString(ARG_HANDLE); } + private String getResourceString() { + return TwitterResource.generate(fingerprint); + } + @NonNull @Override public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { @@ -76,8 +78,7 @@ public class LinkedIdCreateTwitterStep2Fragment extends LinkedIdCreateFinalFragm @Override LinkedTokenResource getResource(OperationLog log) { - return TwitterResource.searchInTwitterStream(getActivity(), - mResourceHandle, mResourceString, log); + return TwitterResource.searchInTwitterStream(getActivity(), mResourceHandle, getResourceString(), log); } @Override @@ -88,14 +89,14 @@ public class LinkedIdCreateTwitterStep2Fragment extends LinkedIdCreateFinalFragm private void proofShare() { Intent sendIntent = new Intent(); sendIntent.setAction(Intent.ACTION_SEND); - sendIntent.putExtra(Intent.EXTRA_TEXT, mResourceString); + sendIntent.putExtra(Intent.EXTRA_TEXT, getResourceString()); sendIntent.setType("text/plain"); startActivity(sendIntent); } private void proofSend() { Uri.Builder builder = Uri.parse("https://twitter.com/intent/tweet").buildUpon(); - builder.appendQueryParameter("text", mResourceString); + builder.appendQueryParameter("text", getResourceString()); Uri uri = builder.build(); Intent intent = new Intent(Intent.ACTION_VIEW, uri);