cthrace/open-keychain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add newly discussed design decisions for passphrase cache service

Browse Source
This commit is contained in:
Dominik Schürmann
2014-09-10 13:40:51 +02:00
parent d61d846b72
commit f18a8a20ac
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java
View File

@@ -56,6 +56,15 @@ import java.util.Date;
* This service runs in its own process, but is available to all other processes as the main * This service runs in its own process, but is available to all other processes as the main
* passphrase cache. Use the static methods addCachedPassphrase and getCachedPassphrase for * passphrase cache. Use the static methods addCachedPassphrase and getCachedPassphrase for
* convenience. * convenience.
*
* Design decisions:
* - Cache passphrases based on master key ids, but try to unlock before using the subkey id
* (to be compatible with stripped keys)
* - Cache based on master key id so that there is not need to enter a passphrase twice for sign and
* decrypt (if these are two different subkeys)
* - Assume that all passphrases cached here are valid passphrases
* - Do not handle if a keyring contains subkeys with different passphrases. This is not considered
* supported and has not been seen in other OpenPGP implementations
*/ */
public class PassphraseCacheService extends Service { public class PassphraseCacheService extends Service {