Merge pull request #2685 from open-keychain/fix_changing_admin_key__issue_2684

Don't explicitly clear PIN when verifying admin PIN
2021-04-03 14:29:07 +02:00
parent 663fb1259f 178e7856b2
commit df2356995c
1 changed files with 0 additions and 1 deletions
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/securitytoken/SecurityTokenConnection.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/securitytoken/SecurityTokenConnection.java
@@ -414,7 +414,6 @@ public class SecurityTokenConnection {
        // delete secrets from memory
        Arrays.fill(pin, (byte) 0);
        Arrays.fill(transformedPin, (byte) 0);
-        adminPin.removeFromMemory();

        ResponseApdu response = communicate(verifyPw3Command);
        if (!response.isSuccess()) {