cthrace/open-keychain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

some coding practice and potential bug fixes

Browse Source
This commit is contained in:
Thialfihar
2010-05-27 20:27:21 +00:00
parent 570b7a6d8e
commit b42f02ba92
4 changed files with 40 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/org/thialfihar/android/apg/provider/Database.java
View File

@@ -200,7 +200,10 @@ public class Database extends SQLiteOpenHelper {
}
} while (cursor.moveToNext());
}
cursor.close();
if (cursor != null) {
cursor.close();
}
break;
}
@@ -427,7 +430,10 @@ public class Database extends SQLiteOpenHelper {
rowId = mDb.insert(KeyRings.TABLE_NAME, KeyRings.WHO_ID, values);
mStatus = Id.return_value.ok;
}
c.close();
if (c != null) {
c.close();
}
return rowId;
}
@@ -465,11 +471,14 @@ public class Database extends SQLiteOpenHelper {
if (c != null && c.moveToFirst()) {
rowId = c.getLong(0);
mDb.update(UserIds.TABLE_NAME, values,
UserIds._ID + " = ?", new String[] { "" + rowId });
UserIds._ID + " = ?", new String[] { "" + rowId });
} else {
rowId = mDb.insert(UserIds.TABLE_NAME, UserIds.USER_ID, values);
}
c.close();
if (c != null) {
c.close();
}
return rowId;
}
@@ -500,7 +509,10 @@ public class Database extends SQLiteOpenHelper {
}
}
}
c.close();
if (c != null) {
c.close();
}
return keyRing;
}
@@ -522,7 +534,10 @@ public class Database extends SQLiteOpenHelper {
if (c != null && c.moveToFirst()) {
data = c.getBlob(0);
}
c.close();
if (c != null) {
c.close();
}
return data;
}
@@ -539,7 +554,10 @@ public class Database extends SQLiteOpenHelper {
if (c != null && c.moveToFirst()) {
data = c.getBlob(0);
}
c.close();
if (c != null) {
c.close();
}
return data;
}
@@ -561,7 +579,10 @@ public class Database extends SQLiteOpenHelper {
deleteKey(keyId);
} while (c.moveToNext());
}
c.close();
if (c != null) {
c.close();
}
mDb.setTransactionSuccessful();
mDb.endTransaction();