From a432d59d2ccd05d24a955c4aeeb5cc5b7866c5ec Mon Sep 17 00:00:00 2001
From: Tobias Erthal <tobias.erthal@gmail.com>
Date: Wed, 21 Sep 2016 20:09:57 +0200
Subject: [PATCH] fixed KeyNotFound bug, cosmetic changes

---
 .../org/sufficientlysecure/keychain/ui/EditKeyTest.java     | 2 ++
 .../keychain/remote/ui/adapter/SelectSignKeyAdapter.java    | 5 -----
 .../keychain/ui/util/adapter/CursorAdapter.java             | 2 ++
 .../keychain/ui/util/adapter/SectionCursorAdapter.java      | 2 --
 .../keychain/ui/util/recyclerview/RecyclerFragment.java     | 6 ++++--
 5 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/OpenKeychain/src/androidTest/java/org/sufficientlysecure/keychain/ui/EditKeyTest.java b/OpenKeychain/src/androidTest/java/org/sufficientlysecure/keychain/ui/EditKeyTest.java
index 2e0d41f13..139967264 100644
--- a/OpenKeychain/src/androidTest/java/org/sufficientlysecure/keychain/ui/EditKeyTest.java
+++ b/OpenKeychain/src/androidTest/java/org/sufficientlysecure/keychain/ui/EditKeyTest.java
@@ -20,6 +20,8 @@ package org.sufficientlysecure.keychain.ui;
 
 import android.app.Activity;
 import android.content.Intent;
+import android.support.test.espresso.ViewAction;
+import android.support.test.espresso.action.ViewActions;
 import android.support.test.espresso.contrib.RecyclerViewActions;
 import android.support.test.espresso.matcher.ViewMatchers;
 import android.support.test.rule.ActivityTestRule;
diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/remote/ui/adapter/SelectSignKeyAdapter.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/remote/ui/adapter/SelectSignKeyAdapter.java
index 9577f2ef7..1e26d19d0 100644
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/remote/ui/adapter/SelectSignKeyAdapter.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/remote/ui/adapter/SelectSignKeyAdapter.java
@@ -47,11 +47,6 @@ public class SelectSignKeyAdapter extends KeyCursorAdapter<CursorAdapter.KeyCurs
         }
     }
 
-    @Override
-    public long getIdFromCursor(KeyCursor keyCursor) {
-        return keyCursor.getKeyId();
-    }
-
     @Override
     public int getItemViewType(int position) {
         return position == getItemCount() -1 ?
diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/adapter/CursorAdapter.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/adapter/CursorAdapter.java
index 6648d0bc5..511696d24 100644
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/adapter/CursorAdapter.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/adapter/CursorAdapter.java
@@ -52,6 +52,7 @@ public abstract class CursorAdapter<C extends CursorAdapter.AbstractCursor, VH e
      * @param context The context
      */
     public CursorAdapter(Context context, C c) {
+        setHasStableIds(true);
         init(context, c, FLAG_REGISTER_CONTENT_OBSERVER);
     }
 
@@ -64,6 +65,7 @@ public abstract class CursorAdapter<C extends CursorAdapter.AbstractCursor, VH e
      * @see #FLAG_REGISTER_CONTENT_OBSERVER
      */
     public CursorAdapter(Context context, C c, int flags) {
+        setHasStableIds(true);
         init(context, c, flags);
     }
 
diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/adapter/SectionCursorAdapter.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/adapter/SectionCursorAdapter.java
index c1842e052..2fe53652d 100644
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/adapter/SectionCursorAdapter.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/adapter/SectionCursorAdapter.java
@@ -40,8 +40,6 @@ public abstract class SectionCursorAdapter<C extends CursorAdapter.AbstractCurso
 
     public SectionCursorAdapter(Context context, C cursor, int flags, Comparator<T> comparator) {
         super(context, cursor, flags);
-
-        setHasStableIds(false); // because we have additional section items
         setSectionComparator(comparator);
     }
 
diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/recyclerview/RecyclerFragment.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/recyclerview/RecyclerFragment.java
index 8bd3d8572..03bb52c15 100644
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/recyclerview/RecyclerFragment.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/util/recyclerview/RecyclerFragment.java
@@ -352,12 +352,14 @@ public class RecyclerFragment<A extends RecyclerView.Adapter> extends Fragment {
 
     @SuppressWarnings("unchecked")
     private void ensureList() {
-        if (listView != null)
+        if (listView != null) {
             return;
+        }
 
         View root = getView();
-        if (root == null)
+        if (root == null) {
             throw new IllegalStateException("Content view not yet created");
+        }
 
         if (root instanceof RecyclerView) {
             listView = (RecyclerView) root;