cthrace/open-keychain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

inserting api apps redundantly is fine, as long as the signature matches

Browse Source
This commit is contained in:
Vincent Breitmoser
2018-06-29 23:38:53 +02:00
parent 016e7d68ee
commit a2eb6349b8
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
OpenKeychain/src/main/java/org/sufficientlysecure/keychain/provider/ApiAppDao.java
View File

@@ -19,6 +19,7 @@ package org.sufficientlysecure.keychain.provider;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashSet; import java.util.HashSet;
import java.util.List; import java.util.List;
import java.util.Set; import java.util.Set;
@@ -66,9 +67,16 @@ public class ApiAppDao extends AbstractDao {
} }
public void insertApiApp(ApiApp apiApp) { public void insertApiApp(ApiApp apiApp) {
ApiApp existingApiApp = getApiApp(apiApp.package_name());
if (existingApiApp != null) {
if (!Arrays.equals(existingApiApp.package_signature(), apiApp.package_signature())) {
throw new IllegalStateException("Inserting existing api with different signature?!");
}
return;
}
InsertApiApp statement = new ApiAppsModel.InsertApiApp(getWritableDb()); InsertApiApp statement = new ApiAppsModel.InsertApiApp(getWritableDb());
statement.bind(apiApp.package_name(), apiApp.package_signature()); statement.bind(apiApp.package_name(), apiApp.package_signature());
statement.execute(); statement.executeInsert();
} }
public void deleteApiApp(String packageName) { public void deleteApiApp(String packageName) {