cthrace/open-keychain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

do not call digestCalculator.getDigest() twice

Browse Source
This commit is contained in:
Dominik Schürmann
2021-04-29 17:52:31 +02:00
parent f8724d3f42
commit 7cf34b0539
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
OpenKeychain/src/main/java/org/bouncycastle/openpgp/operator/jcajce/NfcSyncPGPContentSignerBuilder.java
View File

@@ -137,12 +137,7 @@ public class NfcSyncPGPContentSignerBuilder
} }
public byte[] getSignature() { public byte[] getSignature() {
byte[] digest; byte[] digest = getDigest();
if (enablePreHash) {
digest = digestCalculator.getDigest();
} else {
digest = ((ByteArrayOutputStream) getOutputStream()).toByteArray();
}
ByteBuffer buf = ByteBuffer.wrap(digest); ByteBuffer buf = ByteBuffer.wrap(digest);
if (signedHashes.containsKey(buf)) { if (signedHashes.containsKey(buf)) {
return (byte[]) signedHashes.get(buf); return (byte[]) signedHashes.get(buf);
@@ -154,6 +149,9 @@ public class NfcSyncPGPContentSignerBuilder
public byte[] getDigest() public byte[] getDigest()
{ {
if (digest != null) {
return digest;
}
if (enablePreHash) { if (enablePreHash) {
digest = digestCalculator.getDigest(); digest = digestCalculator.getDigest();
} else { } else {