cthrace/open-keychain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2300 from open-keychain/keylist-own-key-timestamps

Browse Source 
Slight improvements to key list items
This commit is contained in:
Dominik Schürmann
2018-04-06 14:20:38 +02:00
committed by GitHub
parent c7e393180c a1da52420e
commit 7135525a5a
2 changed files with 42 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/adapter/KeySectionedListAdapter.java
View File

@@ -25,6 +25,7 @@ import android.database.MatrixCursor;
import android.database.MergeCursor; import android.database.MergeCursor;
import android.graphics.PorterDuff; import android.graphics.PorterDuff;
import android.graphics.drawable.Drawable; import android.graphics.drawable.Drawable;
import android.support.annotation.NonNull;
import android.support.v4.content.ContextCompat; import android.support.v4.content.ContextCompat;
import android.text.TextUtils; import android.text.TextUtils;
import android.text.format.DateUtils; import android.text.format.DateUtils;
@@ -62,6 +63,8 @@ public class KeySectionedListAdapter extends SectionCursorAdapter<KeySectionedLi
private static final short VIEW_SECTION_TYPE_PRIVATE = 0x0; private static final short VIEW_SECTION_TYPE_PRIVATE = 0x0;
private static final short VIEW_SECTION_TYPE_PUBLIC = 0x1; private static final short VIEW_SECTION_TYPE_PUBLIC = 0x1;
private static final long JUST_NOW_TIMESPAN = DateUtils.MINUTE_IN_MILLIS * 5;
private String mQuery; private String mQuery;
private List<Integer> mSelected; private List<Integer> mSelected;
private KeyListListener mListener; private KeyListListener mListener;
@@ -387,16 +390,21 @@ public class KeySectionedListAdapter extends SectionCursorAdapter<KeySectionedLi
{ // set name and stuff, common to both key types { // set name and stuff, common to both key types
String name = keyItem.getName(); String name = keyItem.getName();
String email = keyItem.getEmail(); String email = keyItem.getEmail();
if (name != null) { if (name == null) {
if (email != null) {
mMainUserId.setText(highlighter.highlight(email));
mMainUserIdRest.setVisibility(View.GONE);
} else {
mMainUserId.setText(R.string.user_id_no_name);
}
} else {
mMainUserId.setText(highlighter.highlight(name)); mMainUserId.setText(highlighter.highlight(name));
} else { if (email != null) {
mMainUserId.setText(R.string.user_id_no_name); mMainUserIdRest.setText(highlighter.highlight(email));
} mMainUserIdRest.setVisibility(View.VISIBLE);
if (email != null) { } else {
mMainUserIdRest.setText(highlighter.highlight(email)); mMainUserIdRest.setVisibility(View.GONE);
mMainUserIdRest.setVisibility(View.VISIBLE); }
} else {
mMainUserIdRest.setVisibility(View.GONE);
} }
} }
@@ -477,15 +485,8 @@ public class KeySectionedListAdapter extends SectionCursorAdapter<KeySectionedLi
mMainUserId.setTextColor(textColor); mMainUserId.setTextColor(textColor);
mMainUserIdRest.setTextColor(textColor); mMainUserIdRest.setTextColor(textColor);
if (keyItem.hasDuplicate()) { if (keyItem.hasDuplicate() || keyItem.isSecret()) {
String dateTime = DateUtils.formatDateTime(context, mCreationDate.setText(getSecretKeyReadableTime(context, keyItem));
keyItem.getCreationTime(),
DateUtils.FORMAT_SHOW_DATE
| DateUtils.FORMAT_SHOW_TIME
| DateUtils.FORMAT_SHOW_YEAR
| DateUtils.FORMAT_ABBREV_MONTH);
mCreationDate.setText(context.getString(R.string.label_key_created,
dateTime));
mCreationDate.setTextColor(textColor); mCreationDate.setTextColor(textColor);
mCreationDate.setVisibility(View.VISIBLE); mCreationDate.setVisibility(View.VISIBLE);
} else { } else {
@@ -511,6 +512,27 @@ public class KeySectionedListAdapter extends SectionCursorAdapter<KeySectionedLi
} }
} }
@NonNull
private String getSecretKeyReadableTime(Context context, KeyListCursor keyItem) {
long creationMillis = keyItem.getCreationTime();
boolean allowRelativeTimestamp = keyItem.hasDuplicate();
if (allowRelativeTimestamp) {
long creationAgeMillis = System.currentTimeMillis() - creationMillis;
if (creationAgeMillis < JUST_NOW_TIMESPAN) {
return context.getString(R.string.label_key_created_just_now);
}
}
String dateTime = DateUtils.formatDateTime(context,
creationMillis,
DateUtils.FORMAT_SHOW_DATE
| DateUtils.FORMAT_SHOW_TIME
| DateUtils.FORMAT_SHOW_YEAR
| DateUtils.FORMAT_ABBREV_MONTH);
return context.getString(R.string.label_key_created, dateTime);
}
@Override @Override
public void onClick(View v) { public void onClick(View v) {
int pos = getAdapterPosition(); int pos = getAdapterPosition();

3
OpenKeychain/src/main/res/values/strings.xml
View File

@@ -167,7 +167,8 @@
<string name="label_keyservers">"Manage OpenPGP keyservers"</string> <string name="label_keyservers">"Manage OpenPGP keyservers"</string>
<string name="label_key_id">"Key ID"</string> <string name="label_key_id">"Key ID"</string>
<string name="label_key_id_colon">"Key ID:"</string> <string name="label_key_id_colon">"Key ID:"</string>
<string name="label_key_created">"Key created %s"</string> <string name="label_key_created">"Created %s"</string>
<string name="label_key_created_just_now">"Created just now"</string>
<string name="label_key_type">"Type"</string> <string name="label_key_type">"Type"</string>
<string name="label_creation">"Creation"</string> <string name="label_creation">"Creation"</string>
<string name="label_creation_colon">"Creation:"</string> <string name="label_creation_colon">"Creation:"</string>