cthrace/open-keychain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix potential issue with disabled analytics

Browse Source
This commit is contained in:
Vincent Breitmoser
2018-07-17 20:18:36 +02:00
parent 4417ff1a43
commit 5b0d9d927c
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
OpenKeychain/src/main/java/org/sufficientlysecure/keychain/analytics/AnalyticsManager.java
View File

@@ -82,6 +82,10 @@ public class AnalyticsManager implements OnSharedPreferenceChangeListener {
// we generally only track booleans. never snoop around in the user's string settings!! // we generally only track booleans. never snoop around in the user's string settings!!
@Override @Override
public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key) { public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key) {
if (piwikTracker == null) {
return;
}
// small exception: check if the user uses a custom keyserver, or one of the well-known ones // small exception: check if the user uses a custom keyserver, or one of the well-known ones
if (Pref.KEY_SERVERS.equals(key)) { if (Pref.KEY_SERVERS.equals(key)) {
Timber.d("Tracking pref %s", key); Timber.d("Tracking pref %s", key);
@@ -103,8 +107,8 @@ public class AnalyticsManager implements OnSharedPreferenceChangeListener {
} }
// unpack an enum // unpack an enum
if (Pref.THEME.equals(key)) { if (Pref.THEME.equals(key)) {
String value = sharedPreferences.getString(key, "empty"); String value = sharedPreferences.getString(Pref.THEME, "empty");
TrackHelper.track().interaction("pref_" + key, value).with(piwikTracker); TrackHelper.track().interaction("pref_" + Pref.THEME, value).with(piwikTracker);
return; return;
} }
// all other values we track are individual booleans // all other values we track are individual booleans