cthrace/open-keychain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactored switch statements to use constants

Browse Source
This commit is contained in:
Victor Hazali
2016-03-30 06:07:59 +08:00
parent ce70568ff3
commit 5411963aff
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/dialog/EditSubkeyDialogFragment.java
View File

@@ -36,6 +36,10 @@ public class EditSubkeyDialogFragment extends DialogFragment {
public static final int MESSAGE_REVOKE = 2; public static final int MESSAGE_REVOKE = 2;
public static final int MESSAGE_STRIP = 3; public static final int MESSAGE_STRIP = 3;
public static final int MESSAGE_MOVE_KEY_TO_CARD = 4; public static final int MESSAGE_MOVE_KEY_TO_CARD = 4;
public static final int SUBKEY_MENU_CHANGE_EXPIRY = 0;
public static final int SUBKEY_MENU_REVOKE_SUBKEY = 1;
public static final int SUBKEY_MENU_STRIP_SUBKEY = 2;
public static final int SUBKEY_MENU_MOVE_TO_SECURITY_TOKEN = 3;
private Messenger mMessenger; private Messenger mMessenger;
@@ -68,16 +72,16 @@ public class EditSubkeyDialogFragment extends DialogFragment {
@Override @Override
public void onClick(DialogInterface dialog, int which) { public void onClick(DialogInterface dialog, int which) {
switch (which) { switch (which) {
case 0: case SUBKEY_MENU_CHANGE_EXPIRY:
sendMessageToHandler(MESSAGE_CHANGE_EXPIRY, null); sendMessageToHandler(MESSAGE_CHANGE_EXPIRY, null);
break; break;
case 1: case SUBKEY_MENU_REVOKE_SUBKEY:
sendMessageToHandler(MESSAGE_REVOKE, null); sendMessageToHandler(MESSAGE_REVOKE, null);
break; break;
case 2: case SUBKEY_MENU_STRIP_SUBKEY:
showAlertDialog(); showAlertDialog();
break; break;
case 3: case SUBKEY_MENU_MOVE_TO_SECURITY_TOKEN:
sendMessageToHandler(MESSAGE_MOVE_KEY_TO_CARD, null); sendMessageToHandler(MESSAGE_MOVE_KEY_TO_CARD, null);
break; break;
default: default:
@@ -98,7 +102,7 @@ public class EditSubkeyDialogFragment extends DialogFragment {
private void showAlertDialog() { private void showAlertDialog() {
CustomAlertDialogBuilder stripAlertDialog = new CustomAlertDialogBuilder(getActivity()); CustomAlertDialogBuilder stripAlertDialog = new CustomAlertDialogBuilder(getActivity());
stripAlertDialog.setTitle(getResources().getString(R.string.title_alert_strip)). stripAlertDialog.setTitle(getResources().getString(R.string.title_alert_strip)).
setMessage(R.string.alert_strip).setCancelable(true); setMessage(R.string.alert_strip).setCancelable(true);
stripAlertDialog.setPositiveButton(R.string.strip, new DialogInterface.OnClickListener() { stripAlertDialog.setPositiveButton(R.string.strip, new DialogInterface.OnClickListener() {
@Override @Override
public void onClick(DialogInterface dialogInterface, int i) { public void onClick(DialogInterface dialogInterface, int i) {