diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/KeychainApplication.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/KeychainApplication.java index cacceb5d0..446699a81 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/KeychainApplication.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/KeychainApplication.java @@ -77,7 +77,7 @@ public class KeychainApplication extends Application { } */ - // Create APG directory on sdcard if not existing + // Create OpenKeychain directory on sdcard if not existing if (Environment.getExternalStorageState().equals(Environment.MEDIA_MOUNTED)) { if (!Constants.Path.APP_DIR.exists() && !Constants.Path.APP_DIR.mkdirs()) { // ignore this for now, it's not crucial diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/UncachedKeyRing.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/UncachedKeyRing.java index 8856da8b0..d05ce3d5c 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/UncachedKeyRing.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/UncachedKeyRing.java @@ -330,7 +330,7 @@ public class UncachedKeyRing { } if (cert.isLocal()) { - // Creation date in the future? No way! + // Remove revocation certs with "local" flag log.add(LogType.MSG_KC_REVOKE_BAD_LOCAL, indent); modified = PGPPublicKey.removeCertification(modified, zert); badCerts += 1; diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/KeychainIntentService.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/KeychainIntentService.java index 954963fb6..92c64a4e1 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/KeychainIntentService.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/KeychainIntentService.java @@ -92,7 +92,7 @@ import de.measite.minidns.record.Data; import de.measite.minidns.record.TXT; /** - * This Service contains all important long lasting operations for APG. It receives Intents with + * This Service contains all important long lasting operations for OpenKeychain. It receives Intents with * data from the activities or other apps, queues these intents, executes them, and stops itself * after doing them. */ @@ -176,7 +176,6 @@ public class KeychainIntentService extends IntentService implements Progressable public static final String IMPORT_KEY_SERVER = "import_key_server"; // export key - public static final String EXPORT_OUTPUT_STREAM = "export_output_stream"; public static final String EXPORT_FILENAME = "export_filename"; public static final String EXPORT_URI = "export_uri"; public static final String EXPORT_SECRET = "export_secret"; @@ -202,10 +201,6 @@ public class KeychainIntentService extends IntentService implements Progressable // decrypt/verify public static final String RESULT_DECRYPTED_BYTES = "decrypted_data"; - public static final String RESULT_DECRYPT_VERIFY_RESULT = "signature"; - - // export - public static final String RESULT_EXPORT = "exported"; Messenger mMessenger; @@ -839,15 +834,6 @@ public class KeychainIntentService extends IntentService implements Progressable } } - @Override - public int onStartCommand(Intent intent, int flags, int startId) { - if (ACTION_CANCEL.equals(intent.getAction())) { - mActionCanceled.set(true); - return START_NOT_STICKY; - } - return super.onStartCommand(intent, flags, startId); - } - private String getOriginalFilename(Bundle data) throws PgpGeneralException, FileNotFoundException { int target = data.getInt(TARGET); switch (target) { @@ -912,4 +898,13 @@ public class KeychainIntentService extends IntentService implements Progressable break; } } + + @Override + public int onStartCommand(Intent intent, int flags, int startId) { + if (ACTION_CANCEL.equals(intent.getAction())) { + mActionCanceled.set(true); + return START_NOT_STICKY; + } + return super.onStartCommand(intent, flags, startId); + } } diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/util/ShareHelper.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/util/ShareHelper.java index 27f026f80..51e58565f 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/util/ShareHelper.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/util/ShareHelper.java @@ -1,10 +1,3 @@ -package org.sufficientlysecure.keychain.util; - -import android.content.Context; -import android.content.Intent; -import android.content.pm.LabeledIntent; -import android.content.pm.ResolveInfo; -import android.os.Build; /* * Copyright (C) 2014 Dominik Schürmann * @@ -22,6 +15,13 @@ import android.os.Build; * along with this program. If not, see . */ +package org.sufficientlysecure.keychain.util; + +import android.content.Context; +import android.content.Intent; +import android.content.pm.LabeledIntent; +import android.content.pm.ResolveInfo; +import android.os.Build; import android.os.Parcelable; import java.util.ArrayList; @@ -38,7 +38,7 @@ public class ShareHelper { } /** - * Create Intent Chooser but exclude OK's EncryptActivity. + * Create Intent Chooser but exclude specific activites, e.g., EncryptActivity to prevent encrypting again *

* Put together from some stackoverflow posts... */ diff --git a/OpenKeychain/src/main/res/drawable/yubikey_neo.png b/OpenKeychain/src/main/res/drawable/yubikey_neo.png deleted file mode 100644 index d4156eb5e..000000000 Binary files a/OpenKeychain/src/main/res/drawable/yubikey_neo.png and /dev/null differ diff --git a/OpenKeychain/src/main/res/drawable/yubikey_phone.png b/OpenKeychain/src/main/res/drawable/yubikey_phone.png new file mode 100644 index 000000000..6a03501c6 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable/yubikey_phone.png differ diff --git a/OpenKeychain/src/main/res/layout/nfc_activity.xml b/OpenKeychain/src/main/res/layout/nfc_activity.xml index e78fa7c87..034b74a35 100644 --- a/OpenKeychain/src/main/res/layout/nfc_activity.xml +++ b/OpenKeychain/src/main/res/layout/nfc_activity.xml @@ -1,30 +1,24 @@ - + android:paddingTop="16dp" + android:paddingBottom="16dp"> + android:src="@drawable/yubikey_phone" /> - + diff --git a/OpenKeychain/src/main/res/values/strings.xml b/OpenKeychain/src/main/res/values/strings.xml index 59c0ce408..b98f47146 100644 --- a/OpenKeychain/src/main/res/values/strings.xml +++ b/OpenKeychain/src/main/res/values/strings.xml @@ -118,9 +118,9 @@ "Enable ASCII Armor" "Let others know that you're using OpenKeychain" "Writes 'OpenKeychain v2.7' to OpenPGP signatures, ciphertext, and exported keys" - "Use default Yubikey PIN" - Use number keypad for Yubikey PIN - "Uses default PIN (123456) to access Yubikeys over NFC" + "Use default YubiKey PIN" + Use number keypad for YubiKey PIN + "Uses default PIN (123456) to access YubiKeys over NFC" "Signed by:" "Encrypt to:" "Delete file after encryption" @@ -208,7 +208,8 @@ "Please enter a passphrase." "Symmetric encryption." "Enter passphrase for '%s'" - "Enter PIN to access Yubikey for '%s'" + "Enter PIN to access YubiKey for '%s'" + "Hold YubiKey against the back of your device." "Are you sure you want to delete\n%s?" "Successfully deleted." "Select a file first." diff --git a/tools/suppressions.xml b/tools/suppressions.xml index 9173d3a5e..4d8fe5717 100644 --- a/tools/suppressions.xml +++ b/tools/suppressions.xml @@ -6,7 +6,6 @@ -