From 2e7fca846efa2ede882054d3d6c621c4fee691a4 Mon Sep 17 00:00:00 2001
From: Vincent Breitmoser <look@my.amazin.horse>
Date: Thu, 19 Jul 2018 10:31:58 +0200
Subject: [PATCH] never enable analytics if Tor is enabled

---
 .../keychain/analytics/AnalyticsManager.java          | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/analytics/AnalyticsManager.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/analytics/AnalyticsManager.java
index 299f3c899..0d51a6a99 100644
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/analytics/AnalyticsManager.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/analytics/AnalyticsManager.java
@@ -153,10 +153,10 @@ public class AnalyticsManager implements OnSharedPreferenceChangeListener {
     }
 
     public synchronized void refreshSettings(Context context) {
-        boolean analyticsHasConsent = Preferences.getPreferences(context).isAnalyticsHasConsent();
+        boolean shouldEnableAnalytics = shouldEnableAnalytics(context);
         boolean analyticsEnabled = piwikTracker != null;
-        if (analyticsHasConsent != analyticsEnabled) {
-            if (analyticsHasConsent) {
+        if (shouldEnableAnalytics != analyticsEnabled) {
+            if (shouldEnableAnalytics) {
                 TrackerConfig trackerConfig;
                 if (Constants.DEBUG) {
                     trackerConfig = new TrackerConfig("https://piwik.openkeychain.org/", 3, "OpenKeychainDebug");
@@ -172,4 +172,9 @@ public class AnalyticsManager implements OnSharedPreferenceChangeListener {
             }
         }
     }
+
+    private boolean shouldEnableAnalytics(Context context) {
+        Preferences preferences = Preferences.getPreferences(context);
+        return preferences.isAnalyticsHasConsent() && !preferences.getUseTorProxy();
+    }
 }