From 53dd05ccc2e721637da2e0c718673260f1b35beb Mon Sep 17 00:00:00 2001
From: modeco80 <lily.modeco80@protonmail.ch>
Date: Thu, 6 Mar 2025 17:08:58 -0500
Subject: [PATCH] cvmts: Fix protocol error disconnection behavior so it
 actually works

---
 cvmts/src/CollabVMServer.ts | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/cvmts/src/CollabVMServer.ts b/cvmts/src/CollabVMServer.ts
index cd8d14d..876ab3b 100644
--- a/cvmts/src/CollabVMServer.ts
+++ b/cvmts/src/CollabVMServer.ts
@@ -708,9 +708,14 @@ export default class CollabVMServer {
 					break;
 			}
 		} catch (err) {
-			// No
-			this.logger.error(`User ${user?.IP.address} ${user?.username ? `with username ${user?.username}` : ''} sent broken Guacamole: ${err as Error}`);
-			user?.kick();
+			this.logger.error({
+				ip: client.IP.address,
+				username: client.username,
+				error_message: (err as Error).message
+			}, 'Error in CollabVMServer#onMessage.');
+
+			// should probably only do this for protocol errors
+			client.kick();
 		}
 	}