cthrace/collabvm-1.2.ts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

auth: Make more resilant to backend failures

Browse Source
This commit is contained in:
modeco80
2024-05-26 16:33:35 -04:00
parent e184bfb085
commit 173ee8149f
2 changed files with 41 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cvmts/src/AuthManager.ts
View File

@@ -25,12 +25,14 @@ export default class AuthManager {
}) })
}); });
// Make sure the fetch returned okay
if(!response.ok)
throw new Error(`Failed to query quth server: ${response.statusText}`)
let json = (await response.json()) as JoinResponse; let json = (await response.json()) as JoinResponse;
if (!json.success) { if (!json.success)
this.logger.Error(`Failed to query auth server: ${json.error}`); throw new Error(json.error);
process.exit(1);
}
return json; return json;
} }

15
cvmts/src/WSServer.ts
View File

@@ -294,11 +294,12 @@ export default class WSServer {
client.sendMsg(guacutils.encode('login', '0', 'You must connect to the VM before logging in.')); client.sendMsg(guacutils.encode('login', '0', 'You must connect to the VM before logging in.'));
return; return;
} }
var res = await this.auth!.Authenticate(msgArr[1], client); try {
let res = await this.auth!.Authenticate(msgArr[1], client);
if (res.clientSuccess) { if (res.clientSuccess) {
this.logger.Info(`${client.IP.address} logged in as ${res.username}`); this.logger.Info(`${client.IP.address} logged in as ${res.username}`);
client.sendMsg(guacutils.encode('login', '1')); client.sendMsg(guacutils.encode('login', '1'));
var old = this.clients.find((c) => c.username === res.username); let old = this.clients.find((c) => c.username === res.username);
if (old) { if (old) {
// kick() doesnt wait until the user is actually removed from the list and itd be anal to make it do that // kick() doesnt wait until the user is actually removed from the list and itd be anal to make it do that
// so we call connectionClosed manually here. When it gets called on kick(), it will return because the user isn't in the list // so we call connectionClosed manually here. When it gets called on kick(), it will return because the user isn't in the list
@@ -321,6 +322,11 @@ export default class WSServer {
client.kick(); client.kick();
} }
} }
} catch(err) {
this.logger.Error(`Error authenticating client ${client.IP.address}: ${(err as Error).message}`);
// for now?
client.sendMsg(guacutils.encode('login', '0', 'There was an internal error while authenticating. Please let a staff member know as soon as possible'))
}
break; break;
case 'list': case 'list':
client.sendMsg(guacutils.encode('list', this.Config.collabvm.node, this.Config.collabvm.displayname, this.screenHidden ? this.screenHiddenThumb : await this.getThumbnail())); client.sendMsg(guacutils.encode('list', this.Config.collabvm.node, this.Config.collabvm.displayname, this.screenHidden ? this.screenHiddenThumb : await this.getThumbnail()));
@@ -915,7 +921,10 @@ export default class WSServer {
async getThumbnail(): Promise<string> { async getThumbnail(): Promise<string> {
let display = this.VM.GetDisplay(); let display = this.VM.GetDisplay();
if (!display.Connected()) throw new Error('VM display is not connected');
// oh well
if (!display.Connected())
return "";
let buf = await JPEGEncoder.EncodeThumbnail(display.Buffer(), display.Size()); let buf = await JPEGEncoder.EncodeThumbnail(display.Buffer(), display.Size());
return buf.toString('base64'); return buf.toString('base64');